$(document).ready - Code Metrics - Inspection of "change status of links" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90f02e...53fcb4 )

by Maxence

created 2017-06-12 17:28 UTC

$(document).ready B

↳ Parent: js/circles.app.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

124

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	124
rs	8.2857
cc	1
nc	1
nop	0

7 Functions

Rating	Size	Complexity
A	15	1
A	16	1
A	13	3
A	23	1
A	10	1
A	12	1
A	3	1

How to fix Long Method

/*
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2017
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

/** global: OC */
/** global: OCA */
/** global: Notyf */


/** global: nav */
/** global: actions */
/** global: elements */
/** global: results */


var api = OCA.Circles.api;
var curr = {
	circlesType: '',
	circle: 0,
	circleName: '',
	circleLevel: 0,
	circleStatus: '',
	circleMembers: {},
	circleLinks: {},
	searchCircle: '',
	searchFilter: 0,
	searchUser: '',
	allowed_federated: 0,
	allowed_circles: 0,

	defineCircle: function (data) {
		curr.circle = data.circle_id;
		curr.circleName = data.details.name;
		curr.circleSettings = data.details.settings;
		curr.circleLevel = data.details.user.level;
		curr.circleStatus = data.details.user.status;
	}
};

var define = {
	levelMember: 1,
	levelModerator: 4,
	levelAdmin: 8,
	levelOwner: 9,
	linkRemove: 0,
	linkDown: 1,
	linkSetup: 2,
	linkRefused: 4,
	linkRequestSent: 5,
	linkRequested: 6,
	linkUp: 9,
	animationSpeed: 100,
	animationMenuSpeed: 60,

	linkStatus: function (status) {
		s = {

			0: t('circles', 'Link Removed'),
			1: t('circles', 'Link down'),
			2: t('circles', 'Setting link'),
			4: t('circles', 'Request dismissed'),
			5: t('circles', 'Request sent'),
			6: t('circles', 'Link requested'),
			9: t('circles', 'Link up')
		};

		return s[parseInt(status)];
	}
};


$(document).ready(function () {

	/**
	 * @constructs Navigation
	 */
	var Navigation = function () {

		$.extend(Navigation.prototype, curr);
		$.extend(Navigation.prototype, nav);
		$.extend(Navigation.prototype, elements);
		$.extend(Navigation.prototype, actions);
		$.extend(Navigation.prototype, settings);

		$.extend(Navigation.prototype, resultCircles);

		$.extend(Navigation.prototype, resultMembers);

		$.extend(Navigation.prototype, resultLinks);


		this.init();
		this.initTransifex();
		this.retrieveSettings();
	};


	Navigation.prototype = {

		init: function () {
			elements.initElements();
			elements.initUI();
			elements.initTweaks();
			elements.initAnimationNewCircle();
			elements.initExperienceCirclesList();
			elements.initExperienceCircleButtons();
			//elements.initExperienceMemberDetails();
			nav.initNavigation();
		},

		initTransifex: function () {
			t('circles', 'Personal Circle');
			t('circles', 'Hidden Circle');
			t('circles', 'Private Circle');
			t('circles', 'Public Circle');

			t('circles', 'Personal');
			t('circles', 'Hidden');
			t('circles', 'Private');
			t('circles', 'Public');

			t('circles', 'Not a member');
			t('circles', 'Member');
			t('circles', 'Moderator');
			t('circles', 'Admin');
			t('circles', 'Owner');

			t('circles', 'Unknown');
			t('circles', 'Invited');
			t('circles', 'Requesting');
			t('circles', 'Blocked');
			t('circles', 'Kicked');
		},

		retrieveSettings: function () {
			var self = this;

			$.ajax({
				method: 'GET',
				url: OC.generateUrl('/apps/circles/settings'),
			}).done(function (result) {
				self.retrieveSettingsResult(result)

			}).fail(function () {
				self.retrieveSettingsResult({status: -1});
			});
		},

		retrieveSettingsResult: function (result) {
			if (result.status !== 1) {
				return;
			}

			curr.allowed_federated = result.allowed_federated;
			curr.allowed_circles = result.allowed_circles;

			var circleId = window.location.hash.substr(1);
			if (circleId) {
				actions.selectCircle(circleId);
			}
		}

	};


	/**
	 * @constructs Notification
	 */
	var Notification = function () {
		this.initialize();
	};

	Notification.prototype = {

		initialize: function () {

			//noinspection SpellCheckingInspection
			var notyf = new Notyf({
				delay: 5000
			});

			this.onSuccess = function (text) {
				notyf.confirm(text);
			};

			this.onFail = function (text) {
				notyf.alert(text);
			};

		}

	};

	OCA.Circles.Navigation = Navigation;
	OCA.Circles.navigation = new Navigation();

	OCA.Notification = Notification;
	OCA.notification = new Notification();

});



1			/*
2			* Circles - Bring cloud-users closer together.
3			*
4			* This file is licensed under the Affero General Public License version 3 or
5			* later. See the COPYING file.
6			*
7			* @author Maxence Lange <[email protected]>
8			* @copyright 2017
9			* @license GNU AGPL version 3 or any later version
10			*
11			* This program is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU Affero General Public License as
13			* published by the Free Software Foundation, either version 3 of the
14			* License, or (at your option) any later version.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU Affero General Public License for more details.
20			*
21			* You should have received a copy of the GNU Affero General Public License
22			* along with this program. If not, see <http://www.gnu.org/licenses/>.
23			*
24			*/
25
26			/** global: OC */
27			/** global: OCA */
28			/** global: Notyf */
29
30
31			/** global: nav */
32			/** global: actions */
33			/** global: elements */
34			/** global: results */
35
36
37			var api = OCA.Circles.api;
38			var curr = {
39			circlesType: '',
40			circle: 0,
41			circleName: '',
42			circleLevel: 0,
43			circleStatus: '',
44			circleMembers: {},
45			circleLinks: {},
46			searchCircle: '',
47			searchFilter: 0,
48			searchUser: '',
49			allowed_federated: 0,
50			allowed_circles: 0,
51
52			defineCircle: function (data) {
53			curr.circle = data.circle_id;
54			curr.circleName = data.details.name;
55			curr.circleSettings = data.details.settings;
56			curr.circleLevel = data.details.user.level;
57			curr.circleStatus = data.details.user.status;
58			}
59			};
60
61			var define = {
62			levelMember: 1,
63			levelModerator: 4,
64			levelAdmin: 8,
65			levelOwner: 9,
66			linkRemove: 0,
67			linkDown: 1,
68			linkSetup: 2,
69			linkRefused: 4,
70			linkRequestSent: 5,
71			linkRequested: 6,
72			linkUp: 9,
73			animationSpeed: 100,
74			animationMenuSpeed: 60,
75
76			linkStatus: function (status) {
77			s = {
			0 ignored issues – show Bug introduced 2017-06-12 17:30 UTC by Report Bug Copy Issue Report The variable `s` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.s`. Loading history...
78			0: t('circles', 'Link Removed'),
79			1: t('circles', 'Link down'),
80			2: t('circles', 'Setting link'),
81			4: t('circles', 'Request dismissed'),
82			5: t('circles', 'Request sent'),
83			6: t('circles', 'Link requested'),
84			9: t('circles', 'Link up')
85			};
86
87			return s[parseInt(status)];
88			}
89			};
90
91
92			$(document).ready(function () {
93
94			/**
95			* @constructs Navigation
96			*/
97			var Navigation = function () {
98
99			$.extend(Navigation.prototype, curr);
100			$.extend(Navigation.prototype, nav);
101			$.extend(Navigation.prototype, elements);
102			$.extend(Navigation.prototype, actions);
103			$.extend(Navigation.prototype, settings);
			0 ignored issues – show Bug introduced 2017-06-09 16:10 UTC by Report Bug Copy Issue Report The variable `settings` seems to be never declared. If this is a global, consider adding a `/** global: settings */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
104			$.extend(Navigation.prototype, resultCircles);
			0 ignored issues – show Bug introduced 2017-05-29 12:42 UTC by Report Bug Copy Issue Report The variable `resultCircles` seems to be never declared. If this is a global, consider adding a `/** global: resultCircles */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
105			$.extend(Navigation.prototype, resultMembers);
			0 ignored issues – show Bug introduced 2017-05-29 12:42 UTC by Report Bug Copy Issue Report The variable `resultMembers` seems to be never declared. If this is a global, consider adding a `/** global: resultMembers */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
106			$.extend(Navigation.prototype, resultLinks);
			0 ignored issues – show Bug introduced 2017-05-29 12:42 UTC by Report Bug Copy Issue Report The variable `resultLinks` seems to be never declared. If this is a global, consider adding a `/** global: resultLinks */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
107
108			this.init();
109			this.initTransifex();
110			this.retrieveSettings();
111			};
112
113
114			Navigation.prototype = {
115
116			init: function () {
117			elements.initElements();
118			elements.initUI();
119			elements.initTweaks();
120			elements.initAnimationNewCircle();
121			elements.initExperienceCirclesList();
122			elements.initExperienceCircleButtons();
123			//elements.initExperienceMemberDetails();
124			nav.initNavigation();
125			},
126
127			initTransifex: function () {
128			t('circles', 'Personal Circle');
129			t('circles', 'Hidden Circle');
130			t('circles', 'Private Circle');
131			t('circles', 'Public Circle');
132
133			t('circles', 'Personal');
134			t('circles', 'Hidden');
135			t('circles', 'Private');
136			t('circles', 'Public');
137
138			t('circles', 'Not a member');
139			t('circles', 'Member');
140			t('circles', 'Moderator');
141			t('circles', 'Admin');
142			t('circles', 'Owner');
143
144			t('circles', 'Unknown');
145			t('circles', 'Invited');
146			t('circles', 'Requesting');
147			t('circles', 'Blocked');
148			t('circles', 'Kicked');
149			},
150
151			retrieveSettings: function () {
152			var self = this;
153
154			$.ajax({
155			method: 'GET',
156			url: OC.generateUrl('/apps/circles/settings'),
157			}).done(function (result) {
158			self.retrieveSettingsResult(result)
			0 ignored issues – show Coding Style introduced 2017-05-29 11:42 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
159			}).fail(function () {
160			self.retrieveSettingsResult({status: -1});
161			});
162			},
163
164			retrieveSettingsResult: function (result) {
165			if (result.status !== 1) {
166			return;
167			}
168
169			curr.allowed_federated = result.allowed_federated;
170			curr.allowed_circles = result.allowed_circles;
171
172			var circleId = window.location.hash.substr(1);
173			if (circleId) {
174			actions.selectCircle(circleId);
175			}
176			}
177
178			};
179
180
181			/**
182			* @constructs Notification
183			*/
184			var Notification = function () {
185			this.initialize();
186			};
187
188			Notification.prototype = {
189
190			initialize: function () {
191
192			//noinspection SpellCheckingInspection
193			var notyf = new Notyf({
194			delay: 5000
195			});
196
197			this.onSuccess = function (text) {
198			notyf.confirm(text);
199			};
200
201			this.onFail = function (text) {
202			notyf.alert(text);
203			};
204
205			}
206
207			};
208
209			OCA.Circles.Navigation = Navigation;
210			OCA.Circles.navigation = new Navigation();
211
212			OCA.Notification = Notification;
213			OCA.notification = new Notification();
214
215			});
216
217

nextcloud / circles

Push — master ( 90f02e...53fcb4 )

$(document).ready B

Complexity

Size

Duplication

Importance

7 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like